Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit more testing #8053

Merged
merged 45 commits into from
Sep 30, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Sep 2, 2024

This PR is a follow up to #8048 and adds more coverage

@matmair matmair added the CI CI / unit testing ecosystem label Sep 2, 2024
@matmair matmair added this to the 0.17.0 milestone Sep 2, 2024
@matmair matmair self-assigned this Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 9c0d1b2
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66f73f93a323620008f0bd93

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 99.56140% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (a5f2273) to head (9c0d1b2).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/report/tests.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8053      +/-   ##
==========================================
+ Coverage   83.88%   84.36%   +0.48%     
==========================================
  Files        1161     1160       -1     
  Lines       52116    52340     +224     
  Branches     1877     1887      +10     
==========================================
+ Hits        43717    44159     +442     
+ Misses       7934     7707     -227     
- Partials      465      474       +9     
Flag Coverage Δ
backend 86.02% <70.17%> (+0.21%) ⬆️
migrations 42.73% <51.75%> (+0.17%) ⬆️
pui 66.50% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair closed this Sep 24, 2024
@matmair matmair reopened this Sep 24, 2024
@matmair matmair added the full-run Always do a full QC CI run label Sep 25, 2024
@matmair matmair closed this Sep 25, 2024
@matmair matmair reopened this Sep 25, 2024
@matmair matmair marked this pull request as ready for review September 30, 2024 21:42
@matmair
Copy link
Member Author

matmair commented Sep 30, 2024

@SchrodingersGat this is ready for review; stock is still not 100% but there is a lot of surface to cover and small PRs are less likely to break stuff

@SchrodingersGat SchrodingersGat merged commit 96a2517 into inventree:master Sep 30, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the app-stock-coverage branch September 30, 2024 22:27
@SchrodingersGat
Copy link
Member

Thanks for the additional tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem full-run Always do a full QC CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants